Skip to content

Conversation

@ruisearch42
Copy link
Contributor

Description

Similar to #58599, should have added avg metric for generation length as well.

Related issues

Additional information

Signed-off-by: Rui Qiao <ruisearch42@gmail.com>
@ruisearch42 ruisearch42 requested a review from a team as a code owner November 14, 2025 00:47
@ruisearch42 ruisearch42 added the go add ONLY when ready to merge, run all tests label Nov 14, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new metric for the average generation length to the vLLM dashboard. The implementation is correct and consistent with how other average metrics are calculated in the dashboard. I have one suggestion to improve the readability of the long Prometheus query string.

@ray-gardener ray-gardener bot added serve Ray Serve Related Issue observability Issues related to the Ray Dashboard, Logging, Metrics, Tracing, and/or Profiling llm labels Nov 14, 2025
Signed-off-by: Rui Qiao <ruisearch42@gmail.com>
@ruisearch42 ruisearch42 enabled auto-merge (squash) November 14, 2025 17:49
Copy link
Contributor

@nrghosh nrghosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ruisearch42 lint is blocking merge fyi

Signed-off-by: Rui Qiao <ruisearch42@gmail.com>
@github-actions github-actions bot disabled auto-merge November 14, 2025 18:53
@ruisearch42 ruisearch42 merged commit 5c2c777 into ray-project:master Nov 14, 2025
6 checks passed
ArturNiederfahrenhorst pushed a commit to ArturNiederfahrenhorst/ray that referenced this pull request Nov 16, 2025
## Description

Similar to ray-project#58599, should have
added avg metric for generation length as well.

## Related issues

## Additional information

---------

Signed-off-by: Rui Qiao <ruisearch42@gmail.com>
Aydin-ab pushed a commit to Aydin-ab/ray-aydin that referenced this pull request Nov 19, 2025
## Description

Similar to ray-project#58599, should have
added avg metric for generation length as well.

## Related issues

## Additional information

---------

Signed-off-by: Rui Qiao <ruisearch42@gmail.com>
Signed-off-by: Aydin Abiar <aydin@anyscale.com>
ykdojo pushed a commit to ykdojo/ray that referenced this pull request Nov 27, 2025
## Description

Similar to ray-project#58599, should have
added avg metric for generation length as well.

## Related issues

## Additional information

---------

Signed-off-by: Rui Qiao <ruisearch42@gmail.com>
Signed-off-by: YK <1811651+ykdojo@users.noreply.github.com>
SheldonTsen pushed a commit to SheldonTsen/ray that referenced this pull request Dec 1, 2025
## Description

Similar to ray-project#58599, should have
added avg metric for generation length as well.

## Related issues

## Additional information

---------

Signed-off-by: Rui Qiao <ruisearch42@gmail.com>
Future-Outlier pushed a commit to Future-Outlier/ray that referenced this pull request Dec 7, 2025
## Description

Similar to ray-project#58599, should have
added avg metric for generation length as well.

## Related issues

## Additional information

---------

Signed-off-by: Rui Qiao <ruisearch42@gmail.com>
Signed-off-by: Future-Outlier <eric901201@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go add ONLY when ready to merge, run all tests llm observability Issues related to the Ray Dashboard, Logging, Metrics, Tracing, and/or Profiling serve Ray Serve Related Issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants