-
Notifications
You must be signed in to change notification settings - Fork 7.2k
[Serve.LLM] Add average generation length metric #58611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Rui Qiao <ruisearch42@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a new metric for the average generation length to the vLLM dashboard. The implementation is correct and consistent with how other average metrics are calculated in the dashboard. I have one suggestion to improve the readability of the long Prometheus query string.
python/ray/dashboard/modules/metrics/dashboards/serve_llm_dashboard_panels.py
Show resolved
Hide resolved
nrghosh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ruisearch42 lint is blocking merge fyi
## Description Similar to ray-project#58599, should have added avg metric for generation length as well. ## Related issues ## Additional information --------- Signed-off-by: Rui Qiao <ruisearch42@gmail.com>
## Description Similar to ray-project#58599, should have added avg metric for generation length as well. ## Related issues ## Additional information --------- Signed-off-by: Rui Qiao <ruisearch42@gmail.com> Signed-off-by: Aydin Abiar <aydin@anyscale.com>
## Description Similar to ray-project#58599, should have added avg metric for generation length as well. ## Related issues ## Additional information --------- Signed-off-by: Rui Qiao <ruisearch42@gmail.com> Signed-off-by: YK <1811651+ykdojo@users.noreply.github.com>
## Description Similar to ray-project#58599, should have added avg metric for generation length as well. ## Related issues ## Additional information --------- Signed-off-by: Rui Qiao <ruisearch42@gmail.com>
## Description Similar to ray-project#58599, should have added avg metric for generation length as well. ## Related issues ## Additional information --------- Signed-off-by: Rui Qiao <ruisearch42@gmail.com> Signed-off-by: Future-Outlier <eric901201@gmail.com>
Description
Similar to #58599, should have added avg metric for generation length as well.
Related issues
Additional information